Opened 8 years ago

Last modified 6 weeks ago

#28526 new Cleanup/optimization

Remedy verbose, often unhelpful undefined template variable logging

Reported by: Tim Graham Owned by:
Component: Template system Version: dev
Severity: Normal Keywords:
Cc: Adam Johnson Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As ​discussed on django-developers, ticket #18773 added logging of undefined template variables in Django 1.9 [dc5b01ad05e50ccde688c73c2ed3334a956076b0], however, I've seen several reports of users finding this logging more confusing than helpful. For example, ​admin templates log errors about missing is_popup variables which is how the template are designed (is_popup is only in the contexts of pop ups) and the TECHNICAL_404_TEMPLATE (now django/views/templates/technical_404.html) also logs errors (#26886) without any obvious solution about how to prevent that. Also #28516 shows the many warnings logged for an admin changelist page.

Change History (11)

comment:1 by Tim McCurrach, 2 years ago

Owner: changed from nobody to Tim McCurrach
Status: new → assigned

comment:2 by Tim McCurrach, 2 years ago

Owner: Tim McCurrach removed
Status: assigned → new

comment:3 by Adam Johnson, 15 months ago

Cc: Adam Johnson added

comment:4 by Natalia Bidart, 14 months ago

Ticket #35716 is related, possibly a duplicate.

comment:5 by Sarah Boyce, 6 weeks ago

Has patch: set
Owner: set to Jacob Walls
Status: new → assigned

comment:6 by Sarah Boyce, 6 weeks ago

Patch needs improvement: set

comment:7 by Jacob Walls, 6 weeks ago

Patch needs improvement: unset

comment:8 by Jacob Walls, 6 weeks ago

Summary: Remedy verbose, often unhelpful undefined tempate variable logging → Remedy verbose, often unhelpful undefined template variable logging

comment:9 by Sarah Boyce, 6 weeks ago

Triage Stage: Accepted → Ready for checkin

comment:10 by Sarah Boyce <42296566+sarahboyce@…>, 6 weeks ago

In 7894776b:

Refs #28526 -- Provided URLResolver namespace in technical 404 template.

This avoids looking up the nonexistent "name" attribute on URLResolver,
which logs verbosely.

comment:11 by Sarah Boyce, 6 weeks ago

Has patch: unset
Owner: Jacob Walls removed
Status: assigned → new
Triage Stage: Ready for checkin → Accepted
Note: See TracTickets for help on using tickets.
Back to Top