#28508 closed Bug (fixed)
Error views set background-color but not foreground color
| Reported by: | John Dallahan | Owned by: | Darius Azimi |
|---|---|---|---|
| Component: | Error reporting | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | yes |
Description
CSRF error pages and 404 pages do not set the text color in their inline styles, but they set background-color, making it annoying to view them with dark GTK themes. Relevant lines:
https://github.com/django/django/blob/master/django/views/templates/technical_404.html#L11
https://github.com/django/django/blob/master/django/views/csrf.py#L26
The 500 page does have it set, though:
https://github.com/django/django/blob/master/django/views/templates/technical_500.html#L12
Attachments (1)
Change History (7)
by , 7 years ago
| Attachment: | Screen Shot 2017-08-19 at 14.58.43.png added |
|---|
comment:1 by , 7 years ago
| Component: | Uncategorized → Core (Other) |
|---|---|
| Easy pickings: | set |
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 7 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
To make sure I understand it correctly, using the same text and background from technical_500 on other pages of csrf and technical_404 would correct this issue?
Replying to John Dallahan:
CSRF error pages and 404 pages do not set the text color in their inline styles, but they set background-color, making it annoying to view them with dark GTK themes. Relevant lines:
https://github.com/django/django/blob/master/django/views/templates/technical_404.html#L11
https://github.com/django/django/blob/master/django/views/csrf.py#L26
The 500 page does have it set, though:
https://github.com/django/django/blob/master/django/views/templates/technical_500.html#L12
comment:3 by , 7 years ago
Yes, that should fix the issue. I recommend using a common template which is extended by error views, though.
comment:6 by , 7 years ago
| Component: | Core (Other) → Error reporting |
|---|---|
| Summary: | Error views set background-color bot not foreground color → Error views set background-color but not foreground color |
What the page looks like in my browser