Opened 8 years ago

Last modified 8 months ago

#28504 new Cleanup/optimization

Add hooks into SchemaEditor.alter_field() and reduce complexity

Reported by: Rachel Tobin Owned by: nobody
Component: Migrations Version: 1.11
Severity: Normal Keywords:
Cc: Rachel Tobin, Bhuvnesh Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

This patch adds in hooks into the base alter_field method in BaseDatabaseSchemaEditor so backends are able to augment or override the various actions that occur when altering a field. This also cuts complexity in half, and clarifies the various actions.

PR is ​https://github.com/django/django/pull/8922

According to the ticket's flags, the next step(s) to move this issue forward are:

  • To provide a patch by sending a pull request. Claim the ticket when you start working so that someone else doesn't duplicate effort. Before sending a pull request, review your work against the patch review checklist. Check the "Has patch" flag on the ticket after sending a pull request and include a link to the pull request in the ticket comment when making that update. The usual format is: [https://github.com/django/django/pull/#### PR].

Change History (5)

comment:1 by Rachel Tobin, 8 years ago

Type: New feature → Cleanup/optimization

comment:2 by Tim Graham, 8 years ago

Component: Database layer (models, ORM) → Migrations
Summary: Add hooks into schema alter_field and reduce complexity → Add hooks into SchemaEditor.alter_field() and reduce complexity
Triage Stage: Unreviewed → Accepted

comment:3 by Rachel Tobin, 8 years ago

Cc: Rachel Tobin added

comment:4 by Carlton Gibson, 7 years ago

Has patch: unset

comment:5 by Bhuvnesh, 8 months ago

Cc: Bhuvnesh added
Note: See TracTickets for help on using tickets.
Back to Top