Typo in docs/ref/models/instances.txt Model.from_db() code example

[Lachlan Musicman]

I think it's because of a mislabelling. Note that a new cls is created and it's called new. After that it's referred to as instance.

@classmethod
def from_db(cls, db, field_names, values):
    # Default implementation of from_db() (subject to change and could
    # be replaced with super()).
    if len(values) != len(cls._meta.concrete_fields):
        values = list(values)
        values.reverse()
        values = [
            values.pop() if f.attname in field_names else DEFERRED
            for f in cls._meta.concrete_fields
        ]
    new = cls(*values)
    instance._state.adding = False
    instance._state.db = db
    # customization to store the original field values on the instance
    instance._loaded_values = dict(zip(field_names, values))
    return instance

Should be

    instance = cls(*values)
    instance._state.adding = False
    instance._state.db = db
    # customization to store the original field values on the instance
    instance._loaded_values = dict(zip(field_names, values))
    return instance

[Lachlan Musicman]

Patch file

[Tim Graham <timograham@…>]

In 00093da:

Fixed #28266 -- Fixed typo in docs/ref/models/instances.txt.

[Tim Graham <timograham@…>]

In 84dac491:

[1.11.x] Fixed #28266 -- Fixed typo in docs/ref/models/instances.txt.

Backport of 00093daec9cc61d8af7fcebdbe58e263bea935a3 from master

[Tim Graham <timograham@…>]

In 7b2d4a95:

[1.10.x] Fixed #28266 -- Fixed typo in docs/ref/models/instances.txt.

Backport of 00093daec9cc61d8af7fcebdbe58e263bea935a3 from master