Opened 4 months ago

Closed 4 months ago

Last modified 4 months ago

#28222 closed Bug (fixed)

QuerySet.update_or_create() field validation should allow settable properties in defaults

Reported by: Alex Mykyta Owned by: Alex Mykyta
Component: Database layer (models, ORM) Version: 1.11
Severity: Normal Keywords: 1.11
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description (last modified by Alex Mykyta)

This is an issue related to #27118. Anthony King commented on it but that issue is closed so I am opening a new one. The field validation introduced in 1.11 update_or_create will throw a FieldError if a defaults argument contains a value that is set through an @property.setter on that model. On the other hand create continues to function correctly. Ideally they'd behave consistently.

Here is an example.

# create works, update_or_create does not. Should neither work?
class Choice(models.Model):
        poll = models.ForeignKey(Poll)
        choice_text = models.CharField(max_length=200)
        votes = models.IntegerField(default=0)

        _credit = models.DecimalField('Credit', decimal_places = 5, max_digits=11, null=True)

        @property
        def credit(self):
                return 0 if self._credit is None else self._credit

        @credit.setter
        def credit(self, value):
                self._credit = value


In [7]: mk = Choice.objects.create(credit=123.3, poll_id=1)

In [8]: mk
Out[8]: <Choice: >

In [9]: mk.__dict__
Out[9]:
{'_credit': 123.3,
 '_state': <django.db.models.base.ModelState at 0x1116e3650>,
 'choice_text': u'',
 'id': 2,
 'poll_id': 1,
 'votes': 0}

In [10]: ok = Choice.objects.update_or_create(defaults={'credit':123.3}, poll_id=1)
---------------------------------------------------------------------------
FieldError                                Traceback (most recent call last)
<ipython-input-10-147ffa08785c> in <module>()
----> 1 ok = Choice.objects.update_or_create(defaults={'credit':123.3}, poll_id=1)

/usr/local/lib/python2.7/site-packages/django/db/models/manager.pyc in manager_method(self, *args, **kwargs)
     83         def create_method(name, method):
     84             def manager_method(self, *args, **kwargs):
---> 85                 return getattr(self.get_queryset(), name)(*args, **kwargs)
     86             manager_method.__name__ = method.__name__
     87             manager_method.__doc__ = method.__doc__

/usr/local/lib/python2.7/site-packages/django/db/models/query.pyc in update_or_create(self, defaults, **kwargs)
    474         """
    475         defaults = defaults or {}
--> 476         lookup, params = self._extract_model_params(defaults, **kwargs)
    477         self._for_write = True
    478         with transaction.atomic(using=self.db):

/usr/local/lib/python2.7/site-packages/django/db/models/query.pyc in _extract_model_params(self, defaults, **kwargs)
    530                 "Invalid field name(s) for model %s: '%s'." % (
    531                     self.model._meta.object_name,
--> 532                     "', '".join(sorted(invalid_params)),
    533                 ))
    534         return lookup, params

FieldError: Invalid field name(s) for model Choice: 'credit'.

Change History (9)

comment:1 Changed 4 months ago by Alex Mykyta

Description: modified (diff)

comment:2 Changed 4 months ago by Alex Mykyta

Component: UncategorizedDatabase layer (models, ORM)

comment:3 Changed 4 months ago by Alex Mykyta

Owner: changed from nobody to Alex Mykyta
Status: newassigned

comment:4 Changed 4 months ago by Alex Mykyta

Has patch: set
Triage Stage: UnreviewedReady for checkin
Last edited 4 months ago by Tim Graham (previous) (diff)

comment:5 Changed 4 months ago by Tim Graham

Triage Stage: Ready for checkinAccepted

Please move the pastebin content (which expires in 1 day) to the ticket's description.

The "Ready for checkin" status is set by a patch reviewer, not the patch author.

comment:6 Changed 4 months ago by Alex Mykyta

Description: modified (diff)

Whoops. Sorry, still figuring out the contribution process.

comment:7 Changed 4 months ago by Tim Graham

Patch needs improvement: set
Summary: Django 1.11 update_or_create field validation results in different behaviours between create and update_or_createQuerySet.update_or_create() field validation should allow settable properties in defaults

comment:8 Changed 4 months ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In 37ab3c3f:

Fixed #28222 -- Allowed settable properties in QuerySet.update_or_create()/get_or_create() defaults.

comment:9 Changed 4 months ago by Tim Graham <timograham@…>

In b9abdd92:

[1.11.x] Fixed #28222 -- Allowed settable properties in QuerySet.update_or_create()/get_or_create() defaults.

Backport of 37ab3c3f9d707d6a1896db79c631e920dcb1fb78 from master

Note: See TracTickets for help on using tickets.
Back to Top