Opened 7 years ago

Closed 7 years ago

#28164 closed Cleanup/optimization (fixed)

Properly convert floats in DecimalField.to_python

Reported by: Claude Paroz Owned by: nobody
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Referring to ​this discussion, I think a first step would be to properly convert float values in DecimalField.to_python. I'm aware that a further step will be custom contexts (#26459).

Change History (5)

comment:1 by Claude Paroz, 7 years ago

Has patch: set

​PR

comment:2 by Tim Graham, 7 years ago

Patch needs improvement: set
Triage Stage: Unreviewed → Accepted

comment:3 by Claude Paroz, 7 years ago

Patch needs improvement: unset

comment:4 by Tim Graham, 7 years ago

Triage Stage: Accepted → Ready for checkin

comment:5 by Claude Paroz <claude@…>, 7 years ago

Resolution: → fixed
Status: new → closed

In a87189fc:

Fixed #28164 -- Improved float conversions in DecimalField.to_python

Thanks Tim Graham and Adam Johnson for the reviews.

Note: See TracTickets for help on using tickets.
Back to Top