Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#28138 closed Cleanup/optimization (fixed)

Use cursor output type handler on Oracle.

Reported by: felixxm Owned by: felixxm
Component: Database layer (models, ORM) Version: master
Severity: Normal Keywords: Oracle cx_Oracle
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Cursor.numbersAsStrings is used on Oracle backend to retrieve decimal values as strings and to avoid rounding errors. numbersAsStrings is deprecated since cx_Oracle==5.3 and will be remove in the cx_Oracle==6.0. We should use Cursor.outputtypehandler instead.

Change History (6)

comment:1 Changed 3 years ago by felixxm

Has patch: set

comment:2 Changed 3 years ago by Tim Graham

Triage Stage: UnreviewedReady for checkin

comment:3 Changed 3 years ago by GitHub <noreply@…>

Resolution: fixed
Status: assignedclosed

In 9467752:

Fixed #28138 -- Used ​output type handler instead of numbersAsStrings on Oracle ​cursor.

Thanks Tim Graham for the review.

comment:4 Changed 3 years ago by Mariusz Felisiak <felisiak.mariusz@…>

In d52577b:

[1.11.x] Fixed #28138 -- Used output type handler instead of numbersAsStrings on Oracle cursor.

Thanks Tim Graham for the review.

Backport of 946775227c56d7a4c6a43343b2e88af837f99f49 from master

comment:5 Changed 3 years ago by Mariusz Felisiak <felisiak.mariusz@…>

In 12a3032d:

[1.11.x] Refs #28138 -- Added release notes for d52577b62b3138674807ac74251fab7faed48331.

comment:6 Changed 3 years ago by Tim Graham <timograham@…>

In f3427ccb:

Refs #28138 -- Added release notes for d52577b62b3138674807ac74251fab7faed48331.

Note: See TracTickets for help on using tickets.
Back to Top