Opened 8 years ago

Last modified 3 years ago

#28135 closed Cleanup/optimization

simplify_regex() doesn't handle non-capturing groups — at Version 8

Reported by: German M. Bravo Owned by: Felix Zhang
Component: contrib.admindocs Version: 1.11
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by Mariusz Felisiak)

While using Django REST Framework's Schema generator, I found out they're using simplify_regex(); however, current version has a few shortcomings, namely non-capturing groups are broken.

Change History (8)

comment:1 by Tim Graham, 8 years ago

Component: Uncategorized → contrib.admindocs
Has patch: set
Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Cleanup/optimization

comment:2 by Tim Graham, 8 years ago

Patch needs improvement: set

I left comments for improvement on the PR. Please uncheck "Patch needs improvement" after updating.

comment:3 by David Smith, 4 years ago

Easy pickings: set

comment:4 by Rohith P R, 4 years ago

This PR is no longer related to this issue.

Last edited 4 years ago by Rohith P R (previous) (diff)

comment:5 by Rohith P R, 4 years ago

Has patch: unset
Patch needs improvement: unset

comment:6 by Felix Zhang, 3 years ago

Description: modified (diff)
Owner: changed from nobody to Felix Zhang
Status: new → assigned

comment:7 by Felix Zhang, 3 years ago

Description: modified (diff)
Has patch: set

I have opened a ​pull request that allows simplify_regex() to handle non-capturing groups and additional tests for them in test_simplify_regex().

Last edited 3 years ago by Mariusz Felisiak (previous) (diff)

comment:8 by Mariusz Felisiak, 3 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.
Back to Top