Opened 3 years ago

Last modified 3 years ago

#28135 new Cleanup/optimization

simplify_regex() doesn't handle non-capturing groups

Reported by: German M. Bravo Owned by: nobody
Component: contrib.admindocs Version: 1.11
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no


While using Django REST Framework's Schema generator, I found out they're using simplify_regex(); however, current version has a few shortcomings, namely non-capturing groups are broken.

I added a pull request (see which fixes this problems, it also is faster and handles many more regex patterns. I also extended the test_simplify_regex test.

Change History (2)

comment:1 Changed 3 years ago by Tim Graham

Component: Uncategorizedcontrib.admindocs
Has patch: set
Triage Stage: UnreviewedAccepted
Type: UncategorizedCleanup/optimization

comment:2 Changed 3 years ago by Tim Graham

Patch needs improvement: set

I left comments for improvement on the PR. Please uncheck "Patch needs improvement" after updating.

Note: See TracTickets for help on using tickets.
Back to Top