Opened 8 years ago
Last modified 3 years ago
#28135 closed Cleanup/optimization
simplify_regex() doesn't handle non-capturing groups — at Initial Version
| Reported by: | German M. Bravo | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.admindocs | Version: | 1.11 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
While using Django REST Framework's Schema generator, I found out they're using simplify_regex(); however, current version has a few shortcomings, namely non-capturing groups are broken.
I added a pull request (see https://github.com/django/django/pull/8414) which fixes this problems, it also is faster and handles many more regex patterns. I also extended the test_simplify_regex test.
Note:
See TracTickets
for help on using tickets.