Opened 8 years ago

Closed 8 years ago

#28115 closed Bug (fixed)

geoip2 module broken with ImportError on master

Reported by: Claude Paroz Owned by: Claude Paroz
Component: GIS Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The geoip2 module is currently broken because it can't import django.core.validators.ipv4_re.
The breakage was my commit 277a4dd4b4cc2a2cad77139882f084480751a95a.

The ImportError catching in the __init__ file is currently not specific enough to catch those failures.

Change History (4)

comment:1 by Claude Paroz, 8 years ago

Has patch: set

​PR

comment:2 by Tim Graham, 8 years ago

Summary: geoip2 module broken on master → geoip2 module broken with ImportError on master
Triage Stage: Accepted → Ready for checkin

comment:3 by Claude Paroz <claude@…>, 8 years ago

In 257075d4:

Refs #28115 -- Avoided masking legitimate ImportErrors in geoip2 module

comment:4 by Claude Paroz <claude@…>, 8 years ago

Resolution: → fixed
Status: assigned → closed

In 3f1ba768:

Fixed #28115 -- Fixed IP address validation in geoip2 module

Regression in 277a4dd4b4cc2a2cad77139882f084480751a95a.
Thanks Tim Graham for the test.

Note: See TracTickets for help on using tickets.
Back to Top