Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#28097 closed Bug (fixed)

Incorrect layout of ReadOnlyPasswordHashWidget widget in user admin

Reported by: Claude Paroz Owned by: Tim Graham
Component: contrib.auth Version: 1.11
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

With the new template-based widget rendering, the admin password widget display is a bit awkward. See attached screenshot. Also, I'm not sure if the the nesting of divs is wanted.

Change History (7)

by Claude Paroz, 8 years ago

Attachment: admin_password_widget.png​ added

comment:1 by Aymeric Augustin, 8 years ago

This looks like a regression to me.

comment:2 by Tim Graham, 8 years ago

Component: contrib.admin → contrib.auth
Owner: changed from nobody to Tim Graham
Status: new → assigned
Summary: Strange layout of password widget in user admin → Incorrect layout of ReadOnlyPasswordHashWidget widget in user admin
Triage Stage: Unreviewed → Accepted

comment:3 by Tim Graham, 8 years ago

Has patch: set

​PR

comment:4 by Claude Paroz, 8 years ago

Triage Stage: Accepted → Ready for checkin

Thanks for the fix!

comment:5 by GitHub <noreply@…>, 8 years ago

Resolution: → fixed
Status: assigned → closed

In dff559f:

Fixed #28097 -- Fixed layout of ReadOnlyPasswordHashWidget.

comment:6 by Tim Graham <timograham@…>, 8 years ago

In cf1e682:

[1.11.x] Fixed #28097 -- Fixed layout of ReadOnlyPasswordHashWidget.

Backport of dff559ff83a6aac14de0bbca58101786edf4195f from master

Note: See TracTickets for help on using tickets.
Back to Top