Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#28042 closed Bug (fixed)

mimetype Fallback for attachments passed to EmailMessage.__init__ removed

Reported by: Dariusz Paluch Owned by: Nikolay
Component: Core (Mail) Version: 1.11
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description (last modified by Dariusz Paluch) 

>>> m = EmailMessage(attachments=[('filename1', 'content1',)])
>>> m.attach('filename2', 'content2')
>>> m.attachments
[('filename1', 'content1'),
 ('filename2', 'content2', 'application/octet-stream')]
>>> m.message()
Traceback (most recent call last):
  File "/usr/local/lib/python3.4/dist-packages/IPython/core/interactiveshell.py", line 2881, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
  File "<ipython-input-53-5151166d7cfd>", line 1, in <module>
    m.message()
  File "/usr/local/lib/python3.4/dist-packages/django/core/mail/message.py", line 302, in message
    msg = self._create_message(msg)
  File "/usr/local/lib/python3.4/dist-packages/django/core/mail/message.py", line 399, in _create_message
    return self._create_attachments(msg)
  File "/usr/local/lib/python3.4/dist-packages/django/core/mail/message.py", line 412, in _create_attachments
    msg.attach(self._create_attachment(*attachment))
  File "/usr/local/lib/python3.4/dist-packages/django/core/mail/message.py", line 450, in _create_attachment
    attachment = self._create_mime_attachment(content, mimetype)
  File "/usr/local/lib/python3.4/dist-packages/django/core/mail/message.py", line 422, in _create_mime_attachment
    basetype, subtype = mimetype.split('/', 1)
AttributeError: 'NoneType' object has no attribute 'split'

This code was work in 1.10

Change History (9)

comment:1 Changed 6 years ago by Tim Graham

Component: Uncategorized → Core (Mail)
Description: modified (diff)

Can you please provide code to reproduce the issue?

comment:2 Changed 6 years ago by Dariusz Paluch

Description: modified (diff)

comment:3 Changed 6 years ago by Tim Graham

Severity: Normal → Release blocker
Triage Stage: Unreviewed → Accepted

Regression in 72d541b61cd7b0a14f70242e2207fdb3f600c4d5.

comment:4 Changed 6 years ago by Nikolay

Owner: changed from nobody to Nikolay
Status: new → assigned

comment:5 Changed 6 years ago by Nikolay

Resolution: → fixed
Status: assigned → closed

​https://github.com/django/django/pull/8323

comment:6 Changed 6 years ago by Tim Graham

Has patch: set
Resolution: fixed
Status: closed → new

The ticket is closed when the patch is merged. Please check "Has patch" when adding a pull request. See ​Triaging Tickets for workflow details.

comment:7 Changed 6 years ago by Tim Graham

Patch needs improvement: set

comment:8 Changed 6 years ago by Tim Graham <timograham@…>

Resolution: → fixed
Status: new → closed

In dd00184:

Fixed #28042 -- Fixed crash when using a two-tuple in EmailMessage's attachments arg.

comment:9 Changed 6 years ago by Tim Graham <timograham@…>

In 734e6bb2:

[1.11.x] Fixed #28042 -- Fixed crash when using a two-tuple in EmailMessage's attachments arg.

Backport of dd001848920713fe616c03db6946762e8aa7c4e3 from master

Note: See TracTickets for help on using tickets.
Back to Top