Opened 6 months ago

Last modified 3 months ago

#28009 new Cleanup/optimization

Document and test Field.empty_value for CharField subclasses

Reported by: Matt Braymer-Hayes Owned by:
Component: Documentation Version: 1.11
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Hi folks, question: Do the changes made in #4136 also impact models.CharField subclasses (CommaSeparatedIntegerField, EmailField, SlugField, and URLField) and forms.CharField subclasses (RegexField, EmailField, URLField, GenericIPAddressField, SlugField, and UUIDField)? Based on my review of the code they do, though I may be missing something. If they are, the docstrings and documentation for each of the forms.CharField subclasses should be updated. Additionally, the release notes should mention the other fields impacted. I'm happy to make a PR, if this is the case.

Change History (3)

comment:1 Changed 6 months ago by Tim Graham

Summary: Changes to models.CharField and forms.CharField impact subclasses as wellDocument and test Field.empty_value for CharField subclasses
Triage Stage: UnreviewedAccepted

comment:2 Changed 6 months ago by Daniel Greenfeld

Looking at the source code (https://github.com/django/django/blob/master/django/db/models/fields/__init__.py#L2237) shows that the new CharField behavior is the same for other fields inheriting from it.

comment:3 Changed 3 months ago by Matt Braymer-Hayes

Owner: Matt Braymer-Hayes deleted
Status: assignednew
Note: See TracTickets for help on using tickets.
Back to Top