Opened 8 years ago
Closed 8 years ago
#27952 closed Cleanup/optimization (fixed)
core.validators.validate_slug doesn't mention that only latin letters are accepted.
Reported by: | Serhiy | Owned by: | Paul Sajna |
---|---|---|---|
Component: | Core (Other) | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | yes |
Description (last modified by )
Just adding "latin" to
"Enter a valid 'slug' consisting of letters, numbers, underscores or hyphens."
will fix this.
Change History (11)
comment:1 by , 8 years ago
Description: | modified (diff) |
---|
comment:2 by , 8 years ago
It could be fixed in translations only, yes. Maybe a note to translators?
In current state translators and users have no hint that it's only Latin letters. Cyrillic and other completely different alphabets aside, I guess this regex doesn't even include German umlauts, isn't it?
comment:4 by , 8 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:8 by , 8 years ago
Has patch: | unset |
---|---|
Triage Stage: | Unreviewed → Accepted |
A hint to translators may be best, but I'm not sure how that works. Someone could start a thread on the DevelopersMailingList to propose another solution.
comment:11 by , 8 years ago
Hinting translators with
https://docs.djangoproject.com/en/1.10/topics/i18n/translation/#comments-for-translators looks best to me too. Paul, would you like to do it?
comment:14 by , 8 years ago
Owner: | set to |
---|
I'm not sure about the suggested wording. At least for English speakers, I think "letters" is less confusing than "latin letters".