Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#27873 closed Bug (fixed)

setup_test_environment() doesn't allow ALLOWED_HOSTS to be a tuple

Reported by: Chris Lamb Owned by: nobody
Component: Testing framework Version: 1.11
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Tim Graham)

We previously let ALLOWED_HOSTS to be a tuple but [17e6616] (re. #26666)
regressed on this.

Change History (6)

comment:2 by Tim Graham, 7 years ago

Component: Uncategorized → Testing framework
Description: modified (diff)
Needs tests: set
Severity: Normal → Release blocker
Summary: Don't assume that ALLOWED_HOSTS is a list → setup_test_environment() doesn't allow ALLOWED_HOSTS to be a tuple
Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Bug

comment:3 by Chris Lamb, 7 years ago

​PR

comment:4 by Chris Lamb, 7 years ago

Needs tests: unset

​PR updated with tests

comment:5 by Tim Graham <timograham@…>, 7 years ago

Resolution: → fixed
Status: new → closed

In 339d526d:

Fixed #27873 -- Fixed crash in setup_test_environment() if ALLOWED_HOSTS is a tuple.

Regression in 17e661641ddaf8266e7430d83cfb2039abc55df7

comment:6 by Tim Graham <timograham@…>, 7 years ago

In 5a85f2c:

[1.11.x] Fixed #27873 -- Fixed crash in setup_test_environment() if ALLOWED_HOSTS is a tuple.

Regression in 17e661641ddaf8266e7430d83cfb2039abc55df7

Backport of 339d526d55baffea3bd3cecd0e07ddf644028e8c from master

Note: See TracTickets for help on using tickets.
Back to Top