Opened 7 years ago

Closed 7 years ago

#27868 closed Cleanup/optimization (fixed)

makemessages creates files in '__pycache__' directory by default

Reported by: MikiSoft Owned by: nobody
Component: Core (Management commands) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

When I run said command without --locale parameter, like this:
manage.py makemessages
Then it proceeds to create .PO files in each of the folders in my locale path (which I specified in settings.py of course), but it doesn't skip __pycache__ - it creates files there, too, but it shouldn't do that.

Change History (6)

comment:1 by Claude Paroz, 7 years ago

Do you have Python code inside your locale paths?

comment:2 by MikiSoft, 7 years ago

I had them, but in the meantime I moved them to another directory and removed __pycache__.

comment:3 by Claude Paroz, 7 years ago

Triage Stage: Unreviewed → Accepted
Type: Bug → Cleanup/optimization
Version: 1.10 → master

I guess we should check if dir names look like locale codes.

comment:4 by Claude Paroz, 7 years ago

Has patch: set

​PR

comment:5 by Tim Graham, 7 years ago

Triage Stage: Accepted → Ready for checkin

comment:6 by Claude Paroz <claude@…>, 7 years ago

Resolution: → fixed
Status: new → closed

In 30c984b:

Fixed #27868 -- Filtered locale path subdirectories

Thanks Tim Graham for the review.

Note: See TracTickets for help on using tickets.
Back to Top