#27865 closed Cleanup/optimization (fixed)
Document use of Manager rather than BaseManager for from_queryset()
| Reported by: | Jonatas CD | Owned by: | Jonatas CD |
|---|---|---|---|
| Component: | Documentation | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Following #26953, document the use of Manager rather that BaseManager on 1.9+ to avoid crash with AssertionError.
Currently the example [1] uses BaseManager while in the preceding paragraph is Manager.
[1] https://docs.djangoproject.com/en/dev/topics/db/managers/#from-queryset
Change History (9)
comment:1 by , 9 years ago
| Easy pickings: | unset |
|---|
comment:2 by , 9 years ago
My idea was to keep the example to text - specially after that mentioned ticket.
comment:3 by , 9 years ago
I'm not sure what you mean by "keep the example to text". django.db.models.manager.BaseManager isn't a documented API, so I don't see the reason why we'd need a note saying not to use something that's not documented. Anyway, will you propose a patch?
comment:5 by , 9 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:6 by , 9 years ago
| Triage Stage: | Unreviewed → Someday/Maybe |
|---|
A
BaseManageris defined in that example that's different fromdjango.db.models.manager.BaseManager. Does the example not work as written?