Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#27815 closed Bug (fixed)

contrib.auth.views.LoginView doesn't pass request object to AuthenticationForm

Reported by: zgyarmati Owned by: zgyarmati
Component: contrib.auth Version: 1.11
Severity: Release blocker Keywords: request, LoginView, authenticate
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The request object isn't passed to the LoginView's form_class 'AuthenticationForm' and hence it's not passed to the auth backend's authenticate() method, because LoginView lacks the get_form_kwargs() method override.

Change History (6)

comment:1 by Claude Paroz, 7 years ago

Severity: Normal → Release blocker
Triage Stage: Unreviewed → Accepted

comment:2 by zgyarmati, 7 years ago

Has patch: set

​PR

comment:3 by Tim Graham, 7 years ago

Triage Stage: Accepted → Ready for checkin

comment:4 by Tim Graham <timograham@…>, 7 years ago

Resolution: → fixed
Status: assigned → closed

In 41ba27fe:

Fixed #27815 -- Made LoginView pass the request kwarg to AuthenticationForm.

comment:5 by Tim Graham <timograham@…>, 7 years ago

In f94e1a5d:

[1.11.x] Fixed #27815 -- Made LoginView pass the request kwarg to AuthenticationForm.

Backport of 41ba27fefdd313333d94408802afff36a9eedb83 from master

comment:6 by Tim Graham <timograham@…>, 7 years ago

In 854f695:

Refs #27815 -- Reordered LoginView.get_form_kwargs().

Note: See TracTickets for help on using tickets.
Back to Top