Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#27802 closed Cleanup/optimization (fixed)

Unify datetime_*_sql() methods with others backend date/time operations.

Reported by: Mariusz Felisiak Owned by: Mariusz Felisiak
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Tim Graham)

This is a follow up of the discussion in 24194#comment:6. datetime_extract_sql, datetime_cast_date_sql, datetime_cast_time_sql, datetime_trunc_sql methods behave differently than others date/time operations. They return sql and params whereas the others return just sql. I propose to unify their behavior.

Change History (3)

comment:1 by Tim Graham, 7 years ago

Description: modified (diff)
Has patch: set
Summary: Unified `datetime_*_sql` functions with others backend date/time operations.Unify datetime_*_sql() methods with others backend date/time operations.
Triage Stage: UnreviewedAccepted

comment:2 by Tim Graham <timograham@…>, 7 years ago

Resolution: fixed
Status: assignedclosed

In 15c14f6f:

Fixed #27802 -- Unified return value of db backend datetime SQL methods.

comment:3 by Tim Graham <timograham@…>, 7 years ago

In 6b00af50:

Refs #27802 -- Corrected BaseDatabaseOperations.datetime_extract/trunc_sql() docstrings.

Note: See TracTickets for help on using tickets.
Back to Top