Opened 6 years ago
Closed 6 years ago
#27787 closed Cleanup/optimization (fixed)
call_command() should validate the arguments it receives
| Reported by: | Tim Graham | Owned by: | Chandrakant Kumar |
|---|---|---|---|
| Component: | Core (Management commands) | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
In #27769 it was observed that call_command() doesn't reject unknown options. In that case, noinput=True was passed rather than interactive=False. It would be nice if such errors didn't pass silently.
Change History (10)
comment:1 Changed 6 years ago by
| Owner: | changed from nobody to Srinivas Reddy Thatiparthy |
|---|---|
| Status: | new → assigned |
comment:2 Changed 6 years ago by
| Has patch: | set |
|---|
comment:3 Changed 6 years ago by
| Needs tests: | set |
|---|
comment:5 Changed 6 years ago by
| Patch needs improvement: | set |
|---|
The patch is still not ready for review given tests aren't passing and release notes about possible backwards incompatibilities are missing.
comment:6 Changed 6 years ago by
| Patch needs improvement: | unset |
|---|
comment:7 Changed 6 years ago by
| Owner: | changed from Srinivas Reddy Thatiparthy to Chandrakant Kumar |
|---|
comment:9 Changed 6 years ago by
| Triage Stage: | Accepted → Ready for checkin |
|---|
Note: See
TracTickets for help on using
tickets.
https://github.com/django/django/pull/7976