Opened 8 years ago

Closed 8 years ago

#2773 closed defect (wontfix)

django.views.defaults.server_error should use RequestContext

Reported by: afternoon@… Owned by: jacob
Component: Generic views Version:
Severity: minor Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Context created by the configured context processors is not made available to the standard 500 error page.

Attached a patch, it's a one line change and pretty brainless so no tests.

Attachments (1)

2773.patch (423 bytes) - added by afternoon@… 8 years ago.
Patch to modify django.views.defaults.server_error to pass RequestContext to Template.render()

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by afternoon@…

Patch to modify django.views.defaults.server_error to pass RequestContext to Template.render()

comment:1 Changed 8 years ago by ubernostrum

IIRC this has come up before and was vetoed on the grounds that we should, as far as possible, reduce the number of things that could possibly raise another exception once we're into the 500-handling, but I don't have a reference to it off the top of my head.

comment:2 Changed 8 years ago by ubernostrum

  • Resolution set to wontfix
  • Status changed from new to closed

Yeah, just found it: Adrian reverted RequestContext out of the 500 view in [3193]. Going ahead and marking this wontfix because of that.

Note: See TracTickets for help on using tickets.
Back to Top