SelectDateWidget clears date and month if year is not selected

[tpazderka]

If year is not selected in SelectDateWidget, then all the inputs are cleared as opposed to a state where date or month is missing.

The issue is that SelectDateWidget.value_from_datadict does not return a value that would be matched by SelectDateWidget.date_re.

The returns from SelectDateWidget.value_from_datadict should probably be formatted as follows

return '{:04d}-{:d}-{:d}'.format(y, m, d)

[tpazderka]

Another option would be to modify SelectDateWidget.date_re to math the output from value_from_datadict

date_re = re.compile(r'(\d+)-(\d\d?)-(\d\d?)$')

[Adonys Alea Boffill]

To fix this ticket I changed the regular expresion of SelectDateWidget.date_re from:

date_re = re.compile(r'(\d{4})-(\d\d?)-(\d\d?)$')

to:

date_re = re.compile(r'(\d{4}|0)-(\d\d?)-(\d\d?)$')

I added 0 to the year possible value because 0 is set as default value of year's Select, and I kept the restriction of 4 digits for a valid year value. I added tests for the SelectDateWidget.date_re expression.

[Tim Graham]

Could you please send a pull request rather than attaching a patch to the ticket? Also, it would be better to include non-regression tests (the ones that already pass without the fix) in a separate patch/commit so it's more clear which cases this fixes.

[Adonys Alea Boffill]

OK Tim!, I'll work on that this week... thanks for your comment.

[Adonys Alea Boffill]

I added the pull request... ​https://github.com/django/django/pull/8108, I hope to cover with all expectations.

[Adonys Alea Boffill]

Added PR (​https://github.com/django/django/pull/8206) with non regressions tests suggested by Tim!

[Tim Graham <timograham@…>]

In cd2ad26c:

Fixed #27724 -- Fixed SelectDateWidget redisplay if a year isn't chosen.