Opened 8 years ago

Closed 5 years ago

Last modified 5 years ago

#27679 closed Cleanup/optimization (fixed)

Document that empty formsets display min_num+extra forms

Reported by: Lorenzo Peña Owned by: David Smith
Component: Documentation Version: 1.9
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no
Pull Requests:13313 merged

Description

I already read #22628

To me: min_num is an option for validation and extra is an option for presentation
Currently, in an empty formset, you get min_num+extra empty forms, I think it should be max(min_num, extra) instead

Change History (5)

comment:1 by Tim Graham, 8 years ago

Component: Uncategorized → Forms
Summary: Formsets: min_num and extra → Empty formsets should display max(min_num, extra) rather than min_num+extra
Type: Uncategorized → Cleanup/optimization

You should say a little more to strengthen your proposal. For example, what are the ramifications for backwards compatibility? What does the documentation say about this?

comment:2 by Tim Graham, 8 years ago

Component: Forms → Documentation
Summary: Empty formsets should display max(min_num, extra) rather than min_num+extra → Document that empty formsets display min_num+extra forms
Triage Stage: Unreviewed → Accepted

Looks like this was ​considered previously and rejected due to backwards compatibility. Tentatively accepting as a documentation enhancement pending no further arguments to change the behavior.

comment:3 by David Smith, 5 years ago

Has patch: set
Owner: changed from nobody to David Smith
Status: new → assigned

​PR

Last edited 5 years ago by Mariusz Felisiak (previous) (diff)

comment:4 by GitHub <noreply@…>, 5 years ago

Resolution: → fixed
Status: assigned → closed

In e2e34f4d:

Fixed #27679 -- Doc'd that empty formsets display extra + min_num forms.

comment:5 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

In b2fc5292:

[3.1.x] Fixed #27679 -- Doc'd that empty formsets display extra + min_num forms.

Backport of e2e34f4de3b90f3820ee11d49cc369ef573bc2ef from master

Note: See TracTickets for help on using tickets.
Back to Top