#27655 closed Cleanup/optimization (fixed)
Styleguide missing - Use single quotes instead of double quotes in string
Reported by: | Anton Samarchyan | Owned by: | Tim Graham |
---|---|---|---|
Component: | Documentation | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | desecho@… | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | no | UI/UX: | no |
Description
Use single quotes instead of double quotes in string if the string itself doesn't contain them. (https://github.com/django/django/pull/7470#discussion_r90120125)
I haven't found this code style standard here https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/coding-style/
We should probably add it?
Change History (6)
comment:1 by , 8 years ago
Triage Stage: | Unreviewed → Ready for checkin |
---|---|
Type: | New feature → Cleanup/optimization |
comment:2 by , 8 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:3 by , 8 years ago
Easy pickings: | unset |
---|---|
Owner: | changed from | to
Triage Stage: | Ready for checkin → Accepted |
I'm going to add some other guidelines with common review comments that I make.
comment:4 by , 8 years ago
Has patch: | set |
---|---|
Patch needs improvement: | set |
WIP PR. I might add more guidelines as I think of them.
Note:
See TracTickets
for help on using tickets.
The advice I've been giving is:
I'll commit that if there's no other feedback.