Opened 7 years ago

Last modified 5 weeks ago

#27645 new Cleanup/optimization

Move Settings.__init__ checks to system checks

Reported by: Adam Johnson Owned by:
Component: Core (Other) Version: dev
Severity: Normal Keywords:
Cc: me@…, Ülgen Sarıkavak Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Following #27626 there is some settings validation code in Settings.__init__ which predates the system checks framework and would be better moved to such checks.

Change History (5)

comment:1 by Claude Paroz, 7 years ago

Triage Stage: Unreviewed → Accepted
Version: 1.10 → master

comment:2 by Tim Graham, 7 years ago

I noticed "Django will refuse to start if :setting:SECRET_KEY is not set." in docs/ref/settings.txt." I'm unsure if the behavior should be kept, but system checks aren't executed when running Django through wsgi.py rather than through runserver.

comment:3 by Mariusz Felisiak, 3 years ago

Owner: Adam Johnson removed
Status: assigned → new

comment:4 by Ülgen Sarıkavak, 5 weeks ago

Cc: Ülgen Sarıkavak added

comment:5 by Adam Johnson, 5 weeks ago

948a874425e7d999950a8fa3b6598d9e34a4b861 moved the SECRET_KEY validation so Tim’s comment no longer applies there.

Note: See TracTickets for help on using tickets.
Back to Top