Opened 4 years ago

Last modified 4 years ago

#27645 assigned Cleanup/optimization

Move Settings.__init__ checks to system checks

Reported by: Adam (Chainz) Johnson Owned by: Adam (Chainz) Johnson
Component: Core (Other) Version: master
Severity: Normal Keywords:
Cc: me@… Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


Following #27626 there is some settings validation code in Settings.__init__ which predates the system checks framework and would be better moved to such checks.

Change History (2)

comment:1 Changed 4 years ago by Claude Paroz

Triage Stage: UnreviewedAccepted
Version: 1.10master

comment:2 Changed 4 years ago by Tim Graham

I noticed "Django will refuse to start if :setting:SECRET_KEY is not set." in docs/ref/settings.txt." I'm unsure if the behavior should be kept, but system checks aren't executed when running Django through rather than through runserver.

Note: See TracTickets for help on using tickets.
Back to Top