Opened 7 years ago

Closed 7 years ago

#27615 closed Cleanup/optimization (fixed)

Use native interval type on Oracle

Reported by: Tim Graham Owned by: Mariusz Felisiak
Component: Database layer (models, ORM) Version: 1.10
Severity: Normal Keywords: oracle
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I think we can remove the driver_supports_timedeltas database feature now that ​the issue it's working around is fixed in cx_oracle. See #24033 and the commit: 5ca82e710e2f92b8c5114492205c8764918407d3.

Attachments (1)

27615.diff​ (2.8 KB ) - added by Tim Graham 7 years ago.

Download all attachments as: .zip

Change History (6)

by Tim Graham, 7 years ago

Attachment: 27615.diff​ added

comment:1 by Tim Graham, 7 years ago

Attached is what I thought a patch might look like but runtests.py expressions gives some "ORA-01867: the interval is invalid" errors, so I'll leave this to someone interested in Oracle.

comment:2 by Mariusz Felisiak, 7 years ago

Owner: changed from nobody to Mariusz Felisiak
Status: new → assigned

comment:3 by Mariusz Felisiak, 7 years ago

Has patch: set

​PR

comment:4 by Tim Graham, 7 years ago

Triage Stage: Accepted → Ready for checkin

(pending #27649 to bump the minimum version of cx_Oracle)

comment:5 by Tim Graham <timograham@…>, 7 years ago

Resolution: → fixed
Status: assigned → closed

In 7d14889:

Fixed #27615 -- Used timedeltas as arguments to Oracle database driver.

Removed unused DatabaseFeatures.driver_supports_timedeltas workaround.

Note: See TracTickets for help on using tickets.
Back to Top