Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#27566 closed Cleanup/optimization (fixed)

Clarify documentation of ModelAdmin.save_model and delete_model

Reported by: Doug Harris Owned by: nobody
Component: Documentation Version: 1.10
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

When working with ModelAdmin.save_model() it wasn't clear to me if these were meant to be overriden or if they were hooks. If hooks, did they run before or after save?

The existing documentation say "must save the object" but then also says "Here you can do any pre- or post-save operations."

I've updated the documentation (in a forthcoming PR) in a way that clarifies this.

Change History (3)

comment:1 Changed 4 years ago by Tim Graham

Has patch: set
Triage Stage: UnreviewedAccepted

comment:2 Changed 4 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In 413216fb:

Fixed #27566 -- Clarified overriding ModelAdmin.save_model()/delete_model() docs.

comment:3 Changed 4 years ago by Tim Graham <timograham@…>

In d978b364:

[1.10.x] Fixed #27566 -- Clarified overriding ModelAdmin.save_model()/delete_model() docs.

Backport of 413216fb9fb36c064494fe155effc39e2888161e from master

Note: See TracTickets for help on using tickets.
Back to Top