Opened 7 years ago

Closed 7 years ago

#27523 closed Bug (invalid)

Sitemap ping_google function reverse broken on Django 1.10

Reported by: Adam Johnson Owned by: Adam Johnson
Component: contrib.sitemaps Version: 1.10
Severity: Normal Keywords:
Cc: me@… Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Django 1.10 removed the ability to reverse() URLs using a dotted Python path, but ping_google is left doing so:

if sitemap_url is None:
    try:
        # First, try to get the "index" sitemap URL.
        sitemap_url = reverse('django.contrib.sitemaps.views.index')

Change History (2)

comment:1 by Adam Johnson, 7 years ago

Owner: changed from nobody to Adam Johnson
Status: new → assigned

comment:2 by Adam Johnson, 7 years ago

Resolution: → invalid
Status: assigned → closed

Ok this isn't actually a problem, the Sitemap framework tells you to set name to the dotted path (and always has): ​https://docs.djangoproject.com/en/1.10/ref/contrib/sitemaps/#initialization

It's just our urlconf didn't, and this worked via the pre-1.10 reverse() of dotted paths behaviour.

Note: See TracTickets for help on using tickets.
Back to Top