./manage runserver --nostatic doesn't return a traceback

[Jeroen van Veen]

When running ./manage runserver --nostatic, I expect a traceback to be returned when
a syntax error occurs, and I expect the autoreloader still to be available. Instead, the
runserver command exits like:

usage: manage.py runserver [-h] [--version] [-v {0,1,2,3}]
                           [--settings SETTINGS] [--pythonpath PYTHONPATH]
                           [--traceback] [--no-color] [--ipv6] [--nothreading]
                           [--noreload]
                           [addrport]
manage.py runserver: error: unrecognized arguments: --nostatic

Ticket: ​https://github.com/wearespindle/django/tree/ticket_27522

[Jeroen van Veen]

This is a workaround:

--- __init__.py.orig    2016-11-22 09:58:38.806209538 +0100
+++ __init__.py 2016-11-22 09:58:47.656120244 +0100
@@ -323,6 +323,10 @@
                     apps.all_models = defaultdict(OrderedDict)
                     apps.app_configs = OrderedDict()
                     apps.apps_ready = apps.models_ready = apps.ready = True
+                    # Execute the runserver command, but strip off additional
+                    # parameters that cause the argument parser to fail.
+                    self.fetch_command(subcommand).run_from_argv(self.argv[0:2])
+                    return
 
             # In all other cases, django.setup() is required to succeed.
             else:

[Jeroen van Veen]

Please let me know if it needs some more work! :)

[Tim Graham]

I can reproduce the problem. Without taking a closer look, I'm not sure about the solution. If you could write a test, that would certainly help.

[Tim Graham]

​PR (currently without tests)

[Jeroen van Veen]

I'm trying to figure out where this test should be placed.

[Tim Graham]

Some tests for runserver are in admin_scripts/tests.py. It might be infeasible to test this (for example, fe6ddb837d18bd4e71cd22fc18272d31478b19f2 lacked tests) but it would be nice to try.

[Tim Graham]

Steps to reproduce: modify a Django project to have a syntax error and run runserver --nostatic. You should see the SyntaxError traceback (after this fix) rather than manage.py runserver: error: unrecognized arguments: --nostatic.

I don't think it's feasible to write a test for this so I'll commit the change without one.

[Tim Graham <timograham@…>]

In ed4264c5:

Fixed #27522 -- Fixed runserver autoreload when using staticfile's options.

On a SyntaxError, made runserver exit with a stacktrace when using
contrib.staticfiles's runserver options such as --nostatic.