Opened 8 years ago

Closed 20 months ago

#27505 closed Cleanup/optimization (fixed)

Error messages customization and internationalization in Paginator class

Reported by: Anton Bazhanov Owned by: Marcelo Galigniana
Component: Core (Other) Version: dev
Severity: Normal Keywords:
Cc: Sagar Gajare Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

There is no ability to change error messages raised by Paginator.validate_number method.

Change History (24)

comment:1 by Anton Bazhanov, 8 years ago

Owner: changed from nobody to Anton Bazhanov
Status: new → assigned

comment:3 by Claude Paroz, 8 years ago

Has patch: set
Triage Stage: Unreviewed → Accepted
Version: 1.10 → master

comment:4 by Claude Paroz, 8 years ago

Patch needs improvement: set

comment:5 by Tim Graham <timograham@…>, 8 years ago

In e690eb40:

Refs #27505 -- Made Paginator's exception messsages translatable.

comment:6 by Tim Graham, 8 years ago

Has patch: unset
Patch needs improvement: unset

Strings are now marked for translation. Easing customization of error messages to be done separately.

comment:7 by Mariusz Felisiak, 4 years ago

Owner: Anton Bazhanov removed
Status: assigned → new

comment:8 by Claude Paroz, 3 years ago

Easy pickings: set

comment:9 by Sagar Gajare, 3 years ago

Cc: Sagar Gajare added
Owner: set to Sagar Gajare
Status: new → assigned

comment:10 by Shivan Sivakumaran, 3 years ago

Does this still need work?

in reply to:  10 comment:11 by Mariusz Felisiak, 3 years ago

Replying to Shivan Sivakumaran:

Does this still need work?

Yes, see comment:

... Easing customization of error messages to be done separately.

comment:12 by Mariusz Felisiak, 2 years ago

Owner: Sagar Gajare removed
Status: assigned → new

comment:13 by Pedro Magno Müller, 2 years ago

Owner: set to Pedro Magno Müller
Status: new → assigned

Hi, I'm a new contributor and I'd love to give it a try

in reply to:  13 ; comment:14 by Aman Pandey, 2 years ago

Replying to Pedro Magno Müller:

Hi, I'm a new contributor and I'd love to give it a try

hi are you still working on it or may i take the issue?

comment:15 by Aman Pandey, 2 years ago

Owner: changed from Pedro Magno Müller to Aman Pandey

comment:16 by Aman Pandey, 2 years ago

don't we have a workaround for that like directly import "PageNotAnInteger" and "EmptyPage" Exceptions directly and use them in our logic isn't it , a way to customization .?

Last edited 2 years ago by Aman Pandey (previous) (diff)

in reply to:  14 ; comment:17 by Uzair Ali, 2 years ago

Replying to Aman Pandey:

Replying to Pedro Magno Müller:

Hi, I'm a new contributor and I'd love to give it a try

hi are you still working on it or may i take the issue?

Hello, Can i take this up?

in reply to:  17 comment:18 by Aman Pandey, 2 years ago

surReplying to Uzair Ali:

Replying to Aman Pandey:

Replying to Pedro Magno Müller:

Hi, I'm a new contributor and I'd love to give it a try

hi are you still working on it or may i take the issue?

Hello, Can i take this up?

yea sure but can we work together like ?

comment:19 by Aris Chow, 2 years ago

I am unsure if this customisation is needed anymore as currently, all usages of Paginator.validate_number will have a try/except block to catch the ValueError exception and set it as 1.

comment:20 by Marcelo Galigniana, 20 months ago

Has patch: set
Owner: changed from Aman Pandey to Marcelo Galigniana

​PR

comment:21 by Mariusz Felisiak, 20 months ago

Needs documentation: set
Patch needs improvement: set

comment:22 by Marcelo Galigniana, 20 months ago

Needs documentation: unset
Patch needs improvement: unset

comment:23 by Mariusz Felisiak, 20 months ago

Triage Stage: Accepted → Ready for checkin

comment:24 by Mariusz Felisiak <felisiak.mariusz@…>, 20 months ago

Resolution: → fixed
Status: assigned → closed

In dfc720c:

Fixed #27505 -- Allowed customizing Paginator's error messages.

Note: See TracTickets for help on using tickets.
Back to Top