Opened 4 years ago
Last modified 4 years ago
#27489 assigned Bug
Renaming a model doesn't rename the permission name and codename
| Reported by: | Tim Graham | Owned by: | Morgan Aubert |
|---|---|---|---|
| Component: | contrib.auth | Version: | master |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
After a RenameModel operation, new permissions are created with the name and codename of the new model name rather than renaming the permissions with the old model name. It should be feasible to fix by using an approach similar to f179113e6cbc8ba0a8d4e87e1d4410fb61d63e75 where a RenamePermission operation is injected in the plan after each RenameModel operation.
#26756 requires the same approach except that the RenamePermission operation must be inserted after AlterModelOptions operations with a verbose_name key.
Change History (4)
comment:1 Changed 4 years ago by
| Owner: | changed from nobody to Morgan Aubert |
|---|---|
| Status: | new → assigned |
comment:2 Changed 4 years ago by
comment:3 Changed 4 years ago by
| Has patch: | set |
|---|---|
| Version: | 1.10 → master |
comment:4 Changed 4 years ago by
| Patch needs improvement: | set |
|---|
I left comments for improvement on the patch.
Note: See
TracTickets for help on using
tickets.
Added PR