Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#27461 closed Bug (fixed)

makemigrations router.allow_migrate() calls for consistency checks use incorrect (app_label, model) pairs

Reported by: Joseph Kahn Owned by: nobody
Component: Core (Management commands) Version: 1.10
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As reported in ticket:27200#comment:14, I makemigrations incorrectly calls allow_migrate() for each app with all the models in the project rather than for each app with the app's models. It broke the router I use because it was passing invalid combinations for shards since not all shards have the same models.

[​https://github.com/django/django/pull/7530 PR]

Change History (3)

comment:1 Changed 4 years ago by Tim Graham

Triage Stage: AcceptedReady for checkin

comment:2 Changed 4 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: newclosed

In 373c6c4:

Fixed #27461 -- Fixed incorrect allow_migrate() arguments in makemigrations.

comment:3 Changed 4 years ago by Tim Graham <timograham@…>

In 7fd3797:

[1.10.x] Fixed #27461 -- Fixed incorrect allow_migrate() arguments in makemigrations.

Backport of 373c6c409c310cb61e1e9c9aff4adba379ffd0b4 from master

Note: See TracTickets for help on using tickets.
Back to Top