Opened 8 years ago

Last modified 8 years ago

#27357 new New feature

Variant of FilePathField that uses a Storage backend

Reported by: Curtis Maloney Owned by: nobody
Component: Database layer (models, ORM) Version: 1.10
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes
Pull Requests:How to create a pull request

Description

It seems inconsistent that our FilePathField doesn't use abstracted storage unlike pretty much all other file access.

According to the ticket's flags, the next step(s) to move this issue forward are:

  • To provide a patch by sending a pull request. Claim the ticket when you start working so that someone else doesn't duplicate effort. Before sending a pull request, review your work against the patch review checklist. Check the "Has patch" flag on the ticket after sending a pull request and include a link to the pull request in the ticket comment when making that update. The usual format is: [https://github.com/django/django/pull/#### PR].

Change History (2)

comment:1 by Tim Graham, 8 years ago

Needs documentation: unset

The FilePathField form field looks coupled to the file system (os.walk(), etc). Maybe it would be enough to try to add a storage agnostic file path form field and allow developers to use it with models.FileField. While models.FilePathField takes path, math, recursive, allow_files, and allow_folders arguments, it's not doing anything with them besides passing them to the form field.

comment:2 by Tim Graham, 8 years ago

Triage Stage: UnreviewedAccepted

Tentatively accepting, though a design proposal and a description of the use case is needed.

Note: See TracTickets for help on using tickets.
Back to Top