Opened 18 years ago

Closed 18 years ago

Last modified 18 years ago

#2732 closed enhancement (fixed)

[patch] Fix FastCGI documentation in the shared-hosting case

Reported by: James Crasta <jcrasta@…> Owned by: Jacob
Component: Documentation Version: dev
Severity: normal Keywords: documentation fastcgi
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

When I wrote the fastcgi documentation, I mistakenly put in leading slashes on the RewriteRule, which will not work when using mod_rewrite in .htaccess; This patch fixes that documentation.

Also, I made a small one-line change to core/servers/fastcgi.py to allow it to take keyword-args, updated the documentation to reflect.

Attachments (2)

django-fastcgi-docfix.diff (1.3 KB ) - added by James Crasta <jcrasta@…> 18 years ago.
FastCGI documentation fix
django-fastcgi-runfastcgi-minorfix.diff (429 bytes ) - added by James Crasta <jcrasta@…> 18 years ago.
Minor fix to allow the first argument to runfastcgi to be optional, thus making calling it with kwargs useful

Download all attachments as: .zip

Change History (5)

by James Crasta <jcrasta@…>, 18 years ago

Attachment: django-fastcgi-docfix.diff added

FastCGI documentation fix

comment:1 by Adrian Holovaty, 18 years ago

Resolution: fixed
Status: newclosed

(In [3759]) Fixed #2732 -- Fixed error in FastCGI docs and added keyword-arg support in a FastCGI function. Thanks for the patch, James Crasta

by James Crasta <jcrasta@…>, 18 years ago

Minor fix to allow the first argument to runfastcgi to be optional, thus making calling it with kwargs useful

comment:2 by James Crasta <jcrasta@…>, 18 years ago

Resolution: fixed
Status: closedreopened

I realized that adding the cleaner kwargs syntax wouldn't be all that useful if the first argument to runfastcgi was still required... you'd need to pass an empty list then. I added a one-line patch to fix that.

I figured since this is related to the same addition, I'd just reopen the ticket rather than creating another

comment:3 by Malcolm Tredinnick, 18 years ago

Resolution: fixed
Status: reopenedclosed

(In [3777]) Fixed #2732 -- Allow first positional argument to runfastcgi() to be optional.
Patch from James Crasta.

Note: See TracTickets for help on using tickets.
Back to Top