Code

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#2732 closed enhancement (fixed)

[patch] Fix FastCGI documentation in the shared-hosting case

Reported by: James Crasta <jcrasta@…> Owned by: jacob
Component: Documentation Version: master
Severity: normal Keywords: documentation fastcgi
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

When I wrote the fastcgi documentation, I mistakenly put in leading slashes on the RewriteRule, which will not work when using mod_rewrite in .htaccess; This patch fixes that documentation.

Also, I made a small one-line change to core/servers/fastcgi.py to allow it to take keyword-args, updated the documentation to reflect.

Attachments (2)

django-fastcgi-docfix.diff (1.3 KB) - added by James Crasta <jcrasta@…> 8 years ago.
FastCGI documentation fix
django-fastcgi-runfastcgi-minorfix.diff (429 bytes) - added by James Crasta <jcrasta@…> 8 years ago.
Minor fix to allow the first argument to runfastcgi to be optional, thus making calling it with kwargs useful

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by James Crasta <jcrasta@…>

FastCGI documentation fix

comment:1 Changed 8 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [3759]) Fixed #2732 -- Fixed error in FastCGI docs and added keyword-arg support in a FastCGI function. Thanks for the patch, James Crasta

Changed 8 years ago by James Crasta <jcrasta@…>

Minor fix to allow the first argument to runfastcgi to be optional, thus making calling it with kwargs useful

comment:2 Changed 8 years ago by James Crasta <jcrasta@…>

  • Resolution fixed deleted
  • Status changed from closed to reopened

I realized that adding the cleaner kwargs syntax wouldn't be all that useful if the first argument to runfastcgi was still required... you'd need to pass an empty list then. I added a one-line patch to fix that.

I figured since this is related to the same addition, I'd just reopen the ticket rather than creating another

comment:3 Changed 8 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [3777]) Fixed #2732 -- Allow first positional argument to runfastcgi() to be optional.
Patch from James Crasta.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.