Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#27318 closed Cleanup/optimization (fixed)

Return failed values from memcached.set_many()

Reported by: Florent Fourcot Owned by: Olivier Tabone
Component: Core (Cache system) Version: 1.10
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The set_many method of MemcachedBackend does not return anything, even if both python-memcached and pylibmc libraries return the list of failing keys.

As result, the backend can fail silently.

Attachments (1)

0001-Fixed-27318-Return-list-of-failing-keys-with-set_man.patch (1.2 KB) - added by Florent Fourcot 4 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 4 years ago by Tim Graham

Needs tests: set
Summary: No return of failed values with memcached.set_many()Return failed values from memcached.set_many()
Triage Stage: UnreviewedAccepted
Type: BugCleanup/optimization

As noted on the PR, tests are needed.

comment:2 Changed 4 years ago by Olivier Tabone

Owner: changed from nobody to Olivier Tabone
Status: newassigned

claim the ticket during duth sprints, created a new PR (the other one was just a one liner).

please review the pr.

Added tests, as recommended in the original PR review.
updated the docs

Last edited 4 years ago by Olivier Tabone (previous) (diff)

comment:3 Changed 4 years ago by Tim Graham

Needs tests: unset
Patch needs improvement: set

I left comments for improvement on the PR.

comment:4 Changed 4 years ago by Olivier Tabone

Patch needs improvement: unset

updated the PR, please feel free to review and comment.

comment:5 Changed 4 years ago by Olivier Tabone

updated the PR
rebase from master

comment:6 Changed 4 years ago by Tim Graham

Patch needs improvement: set

comment:7 Changed 3 years ago by Tim Graham

Patch needs improvement: unset

comment:8 Changed 3 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In a027447:

Fixed #27318 -- Made cache.set_many() return the list of failed keys.

comment:9 Changed 3 years ago by Tim Graham <timograham@…>

In abacd09:

Refs #27318 -- Made DummyCache.set_many() return a list for consistency with other backends.

comment:10 Changed 3 years ago by Tim Graham <timograham@…>

In ea901eb:

[2.0.x] Refs #27318 -- Made DummyCache.set_many() return a list for consistency with other backends.

Backport of abacd09f07f4bb0aa1a3a32bc6e3c3570fa76912 from master

Note: See TracTickets for help on using tickets.
Back to Top