Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#27218 closed New feature (fixed)

Return LogEntry instances from log_addition, log_change, log_deletion

Reported by: Claude Paroz Owned by: nobody
Component: contrib.admin Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

For customized ModelAdmin classes, it might be handy to have access to the created LogEntry instances in inherited methods to be able to customize the logging behavior (django-reversion has a use case for that).

I suggest to return the LogEntry instance from those methods (which currently don't return anything).

Change History (5)

comment:1 by Tim Graham, 8 years ago

Triage Stage: Unreviewed → Accepted

comment:2 by Tim Graham, 8 years ago

Has patch: set
Patch needs improvement: set

​PR (with comments for improvement).

comment:3 by François Freitag, 8 years ago

Patch needs improvement: unset

comment:4 by Tim Graham <timograham@…>, 8 years ago

Resolution: → fixed
Status: new → closed

In aa9569fc:

Fixed #27218 -- Returned LogEntry instances from ModelAdmin.log_*() methods.

comment:5 by Tim Graham <timograham@…>, 8 years ago

In e5f5e8ac:

Refs #27218 -- Fixed LogEntry tests on MySQL 5.5.

Note: See TracTickets for help on using tickets.
Back to Top