Sites framework does not normalize domains with trailing "."

[Ran Benita]

I have a Django project which uses the sites framework. The site is picked by the Host and not by setting SITE_ID. Suppose one of the domains is "mysite.com". In DNS, this is equivalent to "mysite.com." (note the trailing dot). The nginx webserver, uwsgi, and Django's own ALLOWED_HOSTS accept "mysite.com." where "mysite.com" is specified. For example, the validate_host() function in http/request.py has this line:

host = host[:-1] if host.endswith('.') else host

which strips the trailing dot if it exists, before matching (this code is not ideal BTW, I think it will not work as intended if the host has a port).

However, the sites framework (in contrib/sites/models.py, SiteManager._get_site_by_request) fails to match in this case. This causes 500 when get_current_site() is called whenever a user requests some URL like "​http://mysite.com./".

It would be nice if the sites framework was fixed to match trailing dot as well, similar to how https://code.djangoproject.com/ticket/24834 was fixed to deal with a Host like "mysite.com:80".

[Tim Graham]

Perhaps http.request.split_domain_port() should remove the trailing dot rather than validate_host() looking for the trailing dot.

[Anton Samarchyan]

Added ​PR 7470

[Anton Samarchyan]

Added tests ​PR 7470

[Anton Samarchyan]

Added test ​PR 7470

[Tim Graham <timograham@…>]

In 05d2c5a:

Fixed #27181 -- Allowed contrib.sites to match domains with trailing ".".