Opened 8 years ago

Closed 8 years ago

#27158 closed Bug (fixed)

Incorrect positioning of admin' horizontal/vertical filter widgets in RTL languages

Reported by: Mehdi Pourfar Owned by: nobody
Component: contrib.admin Version: 1.10
Severity: Normal Keywords: admin, ui, css
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: yes

Description

Admin's filters were floated to left in RTL version and not vertically aligned.

I've fixed it and sent a pull request here.
https://github.com/django/django/pull/7183

Before:
http://sl.uploads.im/t/0B6JX.jpg
After:
http://sk.uploads.im/t/J8AqP.jpg

Change History (5)

comment:1 by Baptiste Mispelon, 8 years ago

Hi,

The screenshots are really small and make it hard to see what's changed exactly.

Could you re-upload them directly to the ticket (use the "Attachments" feature of Trac)?
Thanks.

comment:2 by Mehdi Pourfar, 8 years ago

Hi,
Larger images are here:

http://uploads.im/0B6JX.jpg
http://uploads.im/J8AqP.jpg

I've blurrified images but the only important thing is the position of
filter horizontal boxes that one can see even in thumbnails.
Thank you for your consideration.

comment:3 by Tim Graham, 8 years ago

Easy pickings: unset
Summary: Small issue with positioning admin page filters in RTL languagesIncorrect positioning of admin' horizontal/vertical filter widgets in RTL languages
Triage Stage: UnreviewedAccepted

comment:4 by Tim Graham, 8 years ago

Patch needs improvement: set

comment:5 by Tim Graham <timograham@…>, 8 years ago

Resolution: fixed
Status: newclosed

In 13a8e63:

Fixed #27158 -- Fixed positioning of admin's many-to-many widgets in rtl.css.

Note: See TracTickets for help on using tickets.
Back to Top