Opened 8 years ago

Closed 8 years ago

#27136 closed Cleanup/optimization (fixed)

Change auth forms' autofocus attribute to HTML5 boolean syntax

Reported by: Jon Dufresne Owned by: nobody
Component: contrib.auth Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Similar to #26928.

The autofocus attribute in auth forms is rendered as autofocus="", but it could be rendered as an HTML5 boolean attribute autofocus. As docs now state Django HTML specifically targets HTML5, might as well use the boolean syntax for all boolean attributes.

Example attribute: ​https://github.com/django/django/blob/38cf9ef390eb0cd0703d99893f826153865f6ba6/django/contrib/auth/forms.py#L98

Change History (3)

comment:1 by Tim Graham, 8 years ago

Has patch: set
Triage Stage: Unreviewed → Ready for checkin

​PR looks good. I'm not sure it merits a release note.

comment:2 by Claude Paroz, 8 years ago

I would also for not bloating the release notes with such "details".

comment:3 by GitHub <noreply@…>, 8 years ago

Resolution: → fixed
Status: new → closed

In ae98d40c:

Fixed #27136 -- Changed auth forms' autofocus attribute to HTML5 boolean syntax.

Note: See TracTickets for help on using tickets.
Back to Top