Opened 8 years ago

Closed 8 years ago

#27078 closed Cleanup/optimization (fixed)

Simplify "if" logic inside SQLite's DatabaseCreation._get_test_db_name()

Reported by: Chris Jerdonek Owned by: Chris Jerdonek
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

This ticket is to simplify the "if" logic inside the SQLite backend's DatabaseCreation._get_test_db_name() method somewhat. ​Here is a link to the method implementation.

The logic can be simplified by, for example, (1) eliminating the need to nest the "if" blocks twice, and (2) having the return ':memory:' code path be handled by the same code path as return test_database_name.

Change History (3)

comment:1 by Chris Jerdonek, 8 years ago

Owner: changed from nobody to Chris Jerdonek
Status: new → assigned

comment:2 by Tim Graham, 8 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by Tim Graham <timograham@…>, 8 years ago

Resolution: → fixed
Status: assigned → closed

In 49fcbe73:

Fixed #27078 -- Simplified "if" logic in SQLite's _get_test_db_name().

Note: See TracTickets for help on using tickets.
Back to Top