Opened 6 years ago

Closed 6 years ago

#27057 closed Cleanup/optimization (fixed)

Use _SavedSettings in setup_test_environment() to store pre-test settings

Reported by: Chris Jerdonek Owned by: Chris Jerdonek
Component: Testing framework Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Currently, setup_test_environment() stores pre-test settings in "arbitrary (but related)" modules. See here for the code.

This issue is to simplify this code somewhat and make it more consistent by storing all pre-test settings in the private _SavedSettings class. (See here and subsequent comments for some discussion of this.)

This will also make it easier to write our first unit test of the "common path" of setup_test_environment(). Currently, only the edge case of calling the function twice has its own test.

Change History (4)

comment:1 Changed 6 years ago by Chris Jerdonek

Owner: changed from nobody to Chris Jerdonek
Status: newassigned

comment:2 Changed 6 years ago by Tim Graham

Triage Stage: UnreviewedAccepted

comment:3 Changed 6 years ago by Chris Jerdonek

Has patch: set

I posted a PR for this here.

comment:4 Changed 6 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In 48ede589:

Fixed #27057 -- Made setup_test_environment() store saved settings in one place.

Note: See TracTickets for help on using tickets.
Back to Top