Opened 8 years ago

Closed 8 years ago

#27024 closed Bug (fixed)

BaseGeometryWidget logs a false positive: Error creating geometry from value ''

Reported by: Gavin Wahl Owned by: nobody
Component: GIS Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

When using a form with a PointField (or presumably anything using BaseGeometryWidget), if you

  1. Don't fill out the map field
  2. Cause a ValidationError for another field
  3. Submit the form

This error-level message will be logged:

Error creating geometry from value ''

There should not be any error logged because there is no error. Maybe BaseGeometryWidget.deserialize needs to check for EMPTY_VALUES?

Change History (6)

comment:1 by Tim Graham, 8 years ago

The logging was added by Claude in 9d2e1f065ede189f65e79eb3cb33a33b460a4351. This isn't a new issue in 1.10, is it?

comment:2 by Gavin Wahl, 8 years ago

It's not new in 1.10 -- I'm still on 1.9

comment:3 by Tim Graham, 8 years ago

Summary: Error level message logged: Error creating geometry from value '' → BaseGeometryWidget logs a false positive: Error creating geometry from value ''
Triage Stage: Unreviewed → Accepted

comment:4 by Claude Paroz, 8 years ago

Has patch: set
Version: 1.10 → master

​PR

comment:5 by Tim Graham, 8 years ago

Triage Stage: Accepted → Ready for checkin

comment:6 by Claude Paroz <claude@…>, 8 years ago

Resolution: → fixed
Status: new → closed

In a7863c7:

Fixed #27024 -- Prevented logging error with empty string as geometry widget value

Thanks Gavin Wahl for the report, and Tim Graham for the review.

Note: See TracTickets for help on using tickets.
Back to Top