Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#26972 closed Bug (fixed)

is_collection definition broken in OLMapWidget.js

Reported by: Claude Paroz Owned by: Claude Paroz
Component: GIS Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The instanceof OpenLayers.Geometry.Collection test in OLMapWidget.js to determine if a geometry type is a collection or not is not valid. The Polygon and LineString for example inherits from Collection, but are not collections for what matters in the widget.
I'd like to backport a fix in 1.10 at least, as the widget is badly broken for some geometries.

Reported in https://groups.google.com/forum/#!topic/geodjango/6dTcb9IokBU

Change History (4)

comment:1 Changed 7 years ago by Claude Paroz

Has patch: set

comment:2 Changed 7 years ago by Tim Graham

Triage Stage: UnreviewedReady for checkin

comment:3 Changed 7 years ago by Claude Paroz <claude@…>

Resolution: fixed
Status: newclosed

In f530b4fd:

Fixed #26972 -- Fixed is_collection definition in MapWidget initialization

comment:4 Changed 7 years ago by Claude Paroz <claude@…>

In 39387efb:

[1.10.x] Fixed #26972 -- Fixed is_collection definition in MapWidget initialization

Backport of f530b4fdfc2be3c2a0edcf38ebeb12bb5a4f0b83 from master.

Note: See TracTickets for help on using tickets.
Back to Top