Opened 8 years ago

Closed 8 years ago

#26950 closed Cleanup/optimization (fixed)

Removed unused DatabaseOperations methods

Reported by: Tim Graham Owned by: Anderson Resende
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Grep for each method in django/django/db/backends/base/operations.py, and if it's unused, remove it from there as well as from the database backends that implement it. For example, drop_foreignkey_sql and drop_sequence_sql both appear to be unused.

Change History (4)

comment:1 by Anderson Resende, 8 years ago

Owner: changed from nobody to Anderson Resende
Status: new → assigned

comment:2 by Anderson Resende, 8 years ago

The method check_aggregate_support is not used anymore. Is deprecated. But is at documentation. Should I remove?

comment:3 by Tim Graham, 8 years ago

That method will be removed in Django 2.0 as per the deprecation warning.

comment:4 by Tim Graham <timograham@…>, 8 years ago

Resolution: → fixed
Status: assigned → closed

In 0d12188:

Fixed #26950 -- Removed obsolete DatabaseOperations SQL methods.

Unused as of 2b039d966f6e61a5ffb5ffac25aa198f9043de3d.

Note: See TracTickets for help on using tickets.
Back to Top