Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#26938 closed Bug (fixed)

Template postmortem on debug page contains invalid HTML

Reported by: Jon Dufresne Owned by: Markus Holtermann <info@…>
Component: Error reporting Version: 1.9
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

There is an extra </ul> in the template:

https://github.com/django/django/blob/32cf01c1c1dcd5fa5d700d0e5117778caf947b74/django/views/debug.py#L729

This bug was introduced in 1.9, commit 65a7a0d9eed4f4da9568cf0e7688e7a8c9f01957.

I would appreciate if the fix would be considered for the next 1.9 bug fix release. I use a middleware for HTML validation. After upgrading from 1.8, this middleware is now reporting some 500 pages as invalid instead of showing me the useful information. This was not the case with 1.8.

Change History (6)

comment:1 Changed 3 years ago by Jon Dufresne

Has patch: set

comment:2 Changed 3 years ago by Claude Paroz

Triage Stage: UnreviewedAccepted

comment:3 Changed 3 years ago by Markus Holtermann

Triage Stage: AcceptedReady for checkin

comment:4 Changed 3 years ago by Markus Holtermann <info@…>

Owner: set to Markus Holtermann <info@…>
Resolution: fixed
Status: newclosed

In 348cfccd:

Fixed #26938 -- Fixed invalid HTML in template postmortem on the debug page.

comment:5 Changed 3 years ago by Markus Holtermann <info@…>

In c0026a9:

[1.10.x] Fixed #26938 -- Fixed invalid HTML in template postmortem on the debug page.

Backport of 348cfccd9072f0e08ffe4cfb3946d1dc6a629e86 from master

comment:6 Changed 3 years ago by Markus Holtermann <info@…>

In caec27f:

[1.9.x] Fixed #26938 -- Fixed invalid HTML in template postmortem on the debug page.

Backport of 348cfccd9072f0e08ffe4cfb3946d1dc6a629e86 from master

Note: See TracTickets for help on using tickets.
Back to Top