Remove NoReverseMatch silencing in RedirectView

[Jerome Leclanche]

Relevant code: ​https://github.com/django/django/blob/bc53af13cbf09b0cbac945426c2d51d0ca52fff3/django/views/generic/base.py#L176-L180 (failing the if on line 196)

I'm taking the time to open this ticket because this wasted me a lot of time. I had a typo in my pattern_name, which resulted in a 410 rather than an exception (as one would expect).

The documentation only says a 410 will be returned if "the resulting location is empty, or the url argument is None", but doesn't mention that it can mask errors.

This design should be reconsidered (per the zen of python, errors should never pass silently). Or at the very least, documented.

[Tim Graham]

I don't see a rationale for that decision on the original ticket: #15273. You'll need to write to the DevelopersMailingList to see if there's consensus to change it, otherwise updating the documentation will suffice.

[K2]

Catching NoReverseMatch will be removed
Discusion about this task is here:
​https://groups.google.com/forum/?hl=pl#!searchin/django-developers/$2326911%7Csort:relevance/django-developers/E0sP4i8U_6w/288so2yEBQAJ

[Tim Graham]

​PR

[Tim Graham <timograham@…>]

In fede6526:

Fixed #26911 -- Removed NoReverseMatch silencing in RedirectView.