Code

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#2678 closed defect (fixed)

[patch] Move the list of profanities for the hasNoProfanities validator to the settings file

Reported by: mcroydon Owned by: adrian
Component: Validators Version: master
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Here is a patch against trunk (3738) that moves the list of profanities to be used in the hasNoProfanities validator and the comments framework. If PROFANITIES_LIST is not found in the settings file it will fall back on the defaults that ship with django. The patch includes an addition to the settings documentation.

Attachments (1)

profanities.patch (1.6 KB) - added by mcroydon 8 years ago.
Patch to move profanities list to settings file

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by mcroydon

Patch to move profanities list to settings file

comment:1 Changed 8 years ago by anonymous

  • Summary changed from Move the list of profanities for the hasNoProfanities validator to the settings file to [patch] Move the list of profanities for the hasNoProfanities validator to the settings file

comment:2 Changed 8 years ago by adrian

Good idea. This patch looks fine, with one exception: PROFANITIES_LIST should be defined in global_settings.py, rather than having the comment code call if hasattr(settings, "PROFANITIES_LIST"). I'll take care of this and check it in.

comment:3 Changed 8 years ago by mcroydon

Thanks for the tip Adrian.

comment:4 Changed 8 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [3784]) Fixed #2678 -- Moved the list of profanities for the hasNoProfanities validator
into global_settings. Patch from Matt Croydon.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.