Opened 18 years ago

Closed 18 years ago

Last modified 18 years ago

#2678 closed defect (fixed)

[patch] Move the list of profanities for the hasNoProfanities validator to the settings file

Reported by: mcroydon Owned by: Adrian Holovaty
Component: Validators Version: dev
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Here is a patch against trunk (3738) that moves the list of profanities to be used in the hasNoProfanities validator and the comments framework. If PROFANITIES_LIST is not found in the settings file it will fall back on the defaults that ship with django. The patch includes an addition to the settings documentation.

Attachments (1)

profanities.patch​ (1.6 KB ) - added by mcroydon 18 years ago.
Patch to move profanities list to settings file

Download all attachments as: .zip

Change History (5)

by mcroydon, 18 years ago

Attachment: profanities.patch​ added

Patch to move profanities list to settings file

comment:1 by anonymous, 18 years ago

Summary: Move the list of profanities for the hasNoProfanities validator to the settings file → [patch] Move the list of profanities for the hasNoProfanities validator to the settings file

comment:2 by Adrian Holovaty, 18 years ago

Good idea. This patch looks fine, with one exception: PROFANITIES_LIST should be defined in global_settings.py, rather than having the comment code call if hasattr(settings, "PROFANITIES_LIST"). I'll take care of this and check it in.

comment:3 by mcroydon, 18 years ago

Thanks for the tip Adrian.

comment:4 by Malcolm Tredinnick, 18 years ago

Resolution: → fixed
Status: new → closed

(In [3784]) Fixed #2678 -- Moved the list of profanities for the hasNoProfanities validator
into global_settings. Patch from Matt Croydon.

Note: See TracTickets for help on using tickets.
Back to Top