Opened 5 years ago

Closed 5 years ago

#26779 closed Cleanup/optimization (fixed)

i18n_javascript should take extra_context as argument

Reported by: Shabda Owned by: Shabda
Component: contrib.admin Version: 1.9
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: yes UI/UX: no

Description

All Django admin views connected to urlpatterns take extra_context as argument. So you can say url(r'^admin/', include(admin.site.urls), {'extra_context': {"foo": "bar"}}) except that it will break for jsi18n endpoint.

This can be fixed by making i18n_javascript view take extra_context.

Change History (5)

comment:1 Changed 5 years ago by Shabda

Owner: changed from nobody to Shabda
Status: newassigned

comment:3 Changed 5 years ago by Tim Graham

Needs tests: set
Triage Stage: UnreviewedAccepted
Type: BugCleanup/optimization

A test is also needed.

comment:4 Changed 5 years ago by Tobias McNulty

Needs tests: unset
Patch needs improvement: set

comment:5 Changed 5 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In b0acb1e7:

Fixed #26779 -- Added extra_context parameter to admin's i18n_javascript view.

Note: See TracTickets for help on using tickets.
Back to Top