Make dbshell exit with the shell's error code

[Étienne BERSAC]

For scripting, commands should return a non zero exit-code on error. But dbshell seems to ignore the exit code. Here is how to reproduce:

(venv) $ echo 'auieaui;' | django-admin dbshell
ERROR:  syntax error at or near "auieaui"
LINE 1: auieaui;
        ^
(venv) $ echo $?
0

I suggested a fix in ​https://github.com/django/django/pull/6768 . @charettes asked me to open a ticket for discussion. Here your are :)

Regards,
Étienne

[Tim Graham]

Is a similar fix applicable for the other database backends? Not sure if tests are feasible.

[Étienne BERSAC]

@timgraham, thanks for triaging :)

I applied the fix to other backends. That's actually not a problem of backends but how runshell manage subprocess.

[Étienne BERSAC]

You're rigth, it's quite hard to test execvp because by definition, this function never returns.

[Tim Graham <timograham@…>]

In 03f6d27:

Fixed #26751 -- Made dbshell exit with the shell's error code.